Skip to content

fix:DDC meta service health aggregation#500

Merged
morningman merged 1 commit into
apache:masterfrom
Al-assad:codex/fix-ddc-ms-health
Jun 17, 2026
Merged

fix:DDC meta service health aggregation#500
morningman merged 1 commit into
apache:masterfrom
Al-assad:codex/fix-ddc-ms-health

Conversation

@Al-assad

@Al-assad Al-assad commented Jun 17, 2026

Copy link
Copy Markdown
Member

Motivation

kubectl get ddc can still show cluster health as green after one MetaService pod is down. The DDC cluster health aggregation currently only considers FE availability and compute group availability, so MetaService degradation is not reflected in status.clusterHealth.health.

There is also a stale status path: once MetaService Phase becomes Ready, UpdateComponentStatus does not downgrade it when the available MetaService replicas drop below the desired replicas.

Changes

  • Downgrade DDC MetaService Phase to Reconciling when not all desired MetaService replicas are ready on the latest StatefulSet revision.
  • Include DDC MetaService availability and phase in cluster health aggregation:
    • MetaService unavailable -> red
    • MetaService available but not fully ready -> yellow
  • Add unit tests for MetaService phase downgrade and DDC cluster health aggregation.

Tests

go test ./pkg/controller/sub_controller/disaggregated_cluster/metaservice
go test ./pkg/controller -run TestReorganizeStatusConsidersMetaServiceHealth
go test ./pkg/controller/sub_controller/disaggregated_cluster/...

@Al-assad Al-assad changed the title Fix DDC meta service health aggregation fix:DDC meta service health aggregation Jun 17, 2026
@morningman morningman merged commit c074cd2 into apache:master Jun 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants