improve: reject admin management user in webhooks#499
Merged
morningman merged 2 commits intoJun 17, 2026
Conversation
Al-assad
changed the title
…min-management-user # Conflicts: # api/disaggregated/v1/disaggregatedcluster_webhook.go # api/disaggregated/v1/disaggregatedcluster_webhook_test.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using the built-in
adminaccount as the operator management user can leave Doris nodes created in Kubernetes but not successfully registered in FE metadata. The failure is only discovered later through symptoms such asshow backendsreturning fewer BE nodes than the requested replicas. Rejecting this unsupported configuration in admission gives users an immediate and actionable error.Changes
spec.adminUser.name=adminforDorisClusteron create and update.spec.adminUser.name=adminforDorisDisaggregatedClusteron create and update.rootand dedicated management users withNODE_PRIVallowed.Tests
go test ./api/disaggregated/v1 -run 'TestDorisDisaggregatedCluster.*ManagementUser'\n-go test ./api/doris/v1 -run 'TestDorisCluster.*ManagementUser'