Skip to content

chore: code tidy integration tests #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
freakyzoidberg merged 1 commit into from
Dec 15, 2025
Merged

chore: code tidy integration tests #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 15 additions & 21 deletions tests/hll_serialization_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,11 @@ fn get_test_data_path(sub_dir: &str, name: &str) -> PathBuf {
}

fn test_sketch_file(path: PathBuf, expected_cardinality: usize, expected_lg_k: u8) {
let expected = expected_cardinality as f64;

let bytes = fs::read(&path).unwrap();
let sketch1 = HllSketch::deserialize(&bytes).unwrap();
let estimate1 = sketch1.estimate();

assert_eq!(
sketch1.lg_config_k(),
Expand All @@ -54,18 +57,15 @@ fn test_sketch_file(path: PathBuf, expected_cardinality: usize, expected_lg_k: u
// - Small sample sizes (especially n < 100)
// - Out-of-order mode (composite estimator)
// - Variation across implementations
let estimate = sketch1.estimate();
let expected = expected_cardinality as f64;

if expected > 0.0 {
let error_margin = 0.02; // 2% error margin
let lower_bound = expected * (1.0 - error_margin);
let upper_bound = expected * (1.0 + error_margin);

assert!(
estimate >= lower_bound && estimate <= upper_bound,
estimate1 >= lower_bound && estimate1 <= upper_bound,
"Estimate {} outside bounds [{}, {}] for expected {} in {}",
estimate,
estimate1,
lower_bound,
upper_bound,
expected,
Expand All @@ -74,9 +74,9 @@ fn test_sketch_file(path: PathBuf, expected_cardinality: usize, expected_lg_k: u
} else {
// For n=0, estimate should be very close to 0
assert!(
estimate < 1.0,
estimate1 < 1.0,
"Expected near-zero estimate for empty sketch, got {} in {}",
estimate,
estimate1,
path.display()
);
}
Expand All @@ -94,20 +94,19 @@ fn test_sketch_file(path: PathBuf, expected_cardinality: usize, expected_lg_k: u
);

// Check that the sketches are functionally equal
assert!(
sketch1.eq(&sketch2),
assert_eq!(
sketch1,
sketch2,
"Sketches are not equal after round-trip for {}",
path.display()
);

// Verify estimates match after round-trip
let estimate2 = sketch2.estimate();
assert_eq!(
estimate,
estimate2,
"Estimates differ after round-trip: {} vs {} for {}",
estimate,
estimate1,
estimate2,
"Estimates differ after round-trip for {}",
path.display()
);
}
Expand Down Expand Up @@ -197,16 +196,11 @@ fn test_estimate_accuracy() {
let bytes = fs::read(&path).unwrap();
let sketch = HllSketch::deserialize(&bytes).unwrap();
let estimate = sketch.estimate();
let error_pct = (estimate - expected as f64).abs() / expected as f64;
let error_pct = ((estimate - expected as f64).abs() / expected as f64) * 100.;

println!(
"{:<12} {:<12.0} {:<10.3}%",
expected,
estimate,
error_pct * 100.
);
println!("{:<12} {:<12.0} {:<10.3}", expected, estimate, error_pct,);

// All estimates should be within 2% error
assert!(error_pct < 0.02, "Error too high: {:.3}%", error_pct);
assert!(error_pct < 2., "Error too high: {:.3}%", error_pct);
}
}