Preserve field metadata across expressions in logical plans#6920
Merged
Conversation
added 3 commits
July 11, 2023 10:31
- Column and Alias exprs now forward field metadata. - All other expressions return empty metadata.
alamb
approved these changes
Jul 12, 2023
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @dexterduck
The whole way the DFField is implemented is somewhat sad (but has nothing to do with you).
Contributor
|
FYI @mustafasrepo -- related to #6839 -- this is another example where if |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #6886.
Rationale for this change
This change improves support for extension types by allowing access to field metadata at the logical planning stage.
What changes are included in this PR?
ExprSchemable::metadatamethod.ExprSchemable::to_fieldto populate field metadata.metadataandwith_metadatatoDFFieldto matchFieldmethods inarrow-rs.Are these changes tested?
Yes
Are there any user-facing changes?
No