Skip to content

fix: Handle null-aware joins correctly in FilterNullJoinKeys when its enabled#23848

Open
AdamGS wants to merge 3 commits into
apache:mainfrom
AdamGS:adamg/fix-null-aware-filter-null-join-keys
Open

fix: Handle null-aware joins correctly in FilterNullJoinKeys when its enabled#23848
AdamGS wants to merge 3 commits into
apache:mainfrom
AdamGS:adamg/fix-null-aware-filter-null-join-keys

Conversation

@AdamGS

@AdamGS AdamGS commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

Fixes a correctness bug, not sure when that config used/desirable.

This is another thing I ran into during #21585

What changes are included in this PR?

  1. New SLT test
  2. Fix for bug in datafusion-optimizer

Are these changes tested?

Existing tests, and a new SLT test verifying the config change doesn't affect the query result and basic unit test.

Are there any user-facing changes?

None

AdamGS added 2 commits July 23, 2026 16:57
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
@github-actions github-actions Bot added optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt) labels Jul 23, 2026
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.48649% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.74%. Comparing base (7fb2e2c) to head (6e30c04).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
datafusion/optimizer/src/filter_null_join_keys.rs 86.48% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #23848      +/-   ##
==========================================
- Coverage   80.75%   80.74%   -0.01%     
==========================================
  Files        1089     1089              
  Lines      368824   368861      +37     
  Branches   368824   368861      +37     
==========================================
+ Hits       297829   297854      +25     
- Misses      53246    53252       +6     
- Partials    17749    17755       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Optimizer rule FilterNullJoinKeys causes null-aware joins to return incorrect results

2 participants