fix: Handle null-aware joins correctly in FilterNullJoinKeys when its enabled#23848
Open
AdamGS wants to merge 3 commits into
Open
fix: Handle null-aware joins correctly in FilterNullJoinKeys when its enabled#23848AdamGS wants to merge 3 commits into
FilterNullJoinKeys when its enabled#23848AdamGS wants to merge 3 commits into
Conversation
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Signed-off-by: Adam Gutglick <adamgsal@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23848 +/- ##
==========================================
- Coverage 80.75% 80.74% -0.01%
==========================================
Files 1089 1089
Lines 368824 368861 +37
Branches 368824 368861 +37
==========================================
+ Hits 297829 297854 +25
- Misses 53246 53252 +6
- Partials 17749 17755 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FilterNullJoinKeyscauses null-aware joins to return incorrect results #23847 .Rationale for this change
Fixes a correctness bug, not sure when that config used/desirable.
This is another thing I ran into during #21585
What changes are included in this PR?
datafusion-optimizerAre these changes tested?
Existing tests, and a new SLT test verifying the config change doesn't affect the query result and basic unit test.
Are there any user-facing changes?
None