fix: Stop trimming trailing zeros when displaying decimals in SLT tests#23836
Open
AdamGS wants to merge 1 commit into
Open
fix: Stop trimming trailing zeros when displaying decimals in SLT tests#23836AdamGS wants to merge 1 commit into
AdamGS wants to merge 1 commit into
Conversation
AdamGS
force-pushed
the
adamg/decimal-slt
branch
from
July 23, 2026 11:42
82217af to
0eb0669
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23836 +/- ##
==========================================
- Coverage 80.75% 80.75% -0.01%
==========================================
Files 1089 1089
Lines 368809 368823 +14
Branches 368809 368823 +14
==========================================
+ Hits 297837 297841 +4
- Misses 53217 53225 +8
- Partials 17755 17757 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This change makes decimal display in SLT tests more explicit, making it easier to detect changes in precision/scale if the type is not asserted explicitly.
What changes are included in this PR?
Skip "normalizing" (which is just trimming trailing 0s) decimals on display in SLT tests.
Are these changes tested?
Existing tests, including changes to them, and one small SLT test.
Are there any user-facing changes?
None, this is test only.