feat: Support Struct type in approx_distinct#23663
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23663 +/- ##
==========================================
- Coverage 80.66% 80.66% -0.01%
==========================================
Files 1086 1086
Lines 366694 366694
Branches 366694 366694
==========================================
- Hits 295806 295798 -8
- Misses 53265 53266 +1
- Partials 17623 17630 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
mkleen
marked this pull request as ready for review
July 17, 2026 09:30
Jefffrey
approved these changes
Jul 17, 2026
Contributor
|
thanks @mkleen |
Contributor
Author
|
@Jefffrey Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
approx_distinctfunction #22989 but does not close it. More types are coming.Rationale for this change
Structtype forapprox_distinctWhat changes are included in this PR?
HLLAccumulatorandHllGroupsAccumulatorto supportStructaggregate.sltAre these changes tested?
Yes and results are compared to DuckDB:
Are there any user-facing changes?
Yes,
approx_distinctsupports nowStructbut no breaking changes.