Minor: Rephrase MSRV policy to be more explanatory#13668
Merged
Conversation
findepi
reviewed
Dec 5, 2024
comphead
commented
Dec 5, 2024
Member
|
What about slightly different approach to the wording: ## Rust Version Compatibility Policy
The Rust toolchain releases are tracked at [Rust Versions](https://releases.rs) and follow
[semantic versioning](https://semver.org/). A Rust toolchain release can be identified
by a version string like `1.80.0`, or more generally `major.minor.patch`.
A Rust toolchain of given version can be officially released or in preparation,
as stated on the Rust Versions page.
DataFusion's Minimum Required Stable Rust Version (MSRV) policy is the following:
- the four latest stable Rust minor releases are supported.
For example if the stable releases are `1.81.x`, `1.80.x`, `1.79.x`, `1.78.x`, `1.77.x`,
then `1.81.x`, `1.80.x`, `1.79.x`, `1.78.x` are the four latest minor releases and are supported.
- the latest stable release as of four months ago is supported.
For example if the current date is `2024-12-01`, then the latest stable release as of `2024-08-01`
is supported.
Rust occasionally releases patch releases for a stable minor version.
Only the latest patch release for a stable minor version is supported.
We enforce this policy using a [MSRV CI Check](https://github.com/search?q=repo%3Aapache%2Fdatafusion+rust-version+language%3ATOML+path%3A%2F%5ECargo.toml%2F&type=code) |
Contributor
Author
I like part about semver so its removes ambiguity about major and minor versions. For the policy itself I feel it can be easier to read... let me reword it |
Contributor
Author
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 11, 2024
* Minor: Rephrase MSRV policy to be more explanatory Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * MSRV policy update --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
zhuliquan
pushed a commit
to zhuliquan/datafusion
that referenced
this pull request
Dec 15, 2024
* Minor: Rephrase MSRV policy to be more explanatory Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * MSRV policy update --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Looks like the MSRV policy on hotfixes can be slightly reworded and improved
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?