Skip to content

Increase minimum supported Rust version (MSRV) to 1.80#13622

Merged
comphead merged 2 commits into
apache:mainfrom
findepi:findepi/increase-minimum-supported-rust-version-msrv-to-1-80-75ed5d
Dec 3, 2024
Merged

Increase minimum supported Rust version (MSRV) to 1.80#13622
comphead merged 2 commits into
apache:mainfrom
findepi:findepi/increase-minimum-supported-rust-version-msrv-to-1-80-75ed5d

Conversation

@findepi

@findepi findepi commented Dec 2, 2024

Copy link
Copy Markdown
Member

Current goal is to support four last stable versions or versions for 4 months whichever is lower. Given 1.80.0 was released on: 25 July, 2024 it's over 4 months old and 1.79 does not need to be supported.

Current goal is to support four last stable versions or versions for 4
months whichever is lower.  Given 1.80.0 was released on: 25 July, 2024
it's over 4 months old and 1.79 does not need to be supported.
@github-actions github-actions Bot added core Core DataFusion crate substrait Changes to the substrait crate proto Related to proto crate labels Dec 2, 2024

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi
I feel we also need to change it in the Dockerfile and rust.yml

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi

I agree with @comphead

Here is one place

FROM rust:1.79-bookworm AS builder

I tried this and it worked on my machine 👍

docker run rust:1.80-bookworm

worked on my machine

@github-actions github-actions Bot added the development-process Related to development process of DataFusion label Dec 3, 2024

@comphead comphead left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @findepi

@comphead comphead merged commit dc4ae20 into apache:main Dec 3, 2024
@findepi findepi deleted the findepi/increase-minimum-supported-rust-version-msrv-to-1-80-75ed5d branch December 4, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core Core DataFusion crate development-process Related to development process of DataFusion proto Related to proto crate substrait Changes to the substrait crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants