Skip to content

Add unit test for constant folding on values#1355

Merged
alamb merged 3 commits into
apache:masterfrom
viirya:issue_1170
Nov 24, 2021
Merged

Add unit test for constant folding on values#1355
alamb merged 3 commits into
apache:masterfrom
viirya:issue_1170

Conversation

@viirya

@viirya viirya commented Nov 24, 2021

Copy link
Copy Markdown
Member

Which issue does this PR close?

Closes #1170.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@viirya

viirya commented Nov 24, 2021

Copy link
Copy Markdown
Member Author

cc @jimexist @alamb

@alamb alamb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks @viirya

@alamb alamb merged commit 7a35c8f into apache:master Nov 24, 2021
@viirya

viirya commented Nov 24, 2021

Copy link
Copy Markdown
Member Author

Thank you @alamb

xudong963 pushed a commit to xudong963/arrow-datafusion that referenced this pull request Nov 28, 2021
xudong963 pushed a commit to xudong963/arrow-datafusion that referenced this pull request Nov 28, 2021
xudong963 pushed a commit to xudong963/arrow-datafusion that referenced this pull request Nov 28, 2021
xudong963 pushed a commit to xudong963/arrow-datafusion that referenced this pull request Nov 28, 2021
xudong963 pushed a commit to xudong963/arrow-datafusion that referenced this pull request Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

apply constant folding to LogicalPlan::Values

2 participants