Support CREATE TABLE x AS TABLE y#704
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 3587526224
💛 - Coveralls |
sarahyurick
commented
Nov 9, 2022
alamb
reviewed
Nov 11, 2022
sarahyurick
commented
Nov 17, 2022
Contributor
Author
|
Hi @alamb, let me know if these updates look reasonable 🙂 |
alamb
reviewed
Nov 30, 2022
alamb
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the delay in review @sarahyurick -- this is looking better but not quite ready yet I think
| Values(Values), | ||
| Insert(Statement), | ||
| // TODO: ANSI SQL supports `TABLE` here. | ||
| Table(Box<Table>), |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Contributor
Author
|
Thanks @alamb ! Updated to use |
alamb
approved these changes
Dec 1, 2022
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sarahyurick -- I think this PR now looks good. I have some ideas of how to simplify the code a little more but I'll make a follow on PR with that change.
Thanks again for sticking with this
This was referenced Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #614
My solution was to parse
CREATE TABLE x AS TABLE ythe same asCREATE TABLE x AS SELECT * FROM y.