allow DateTimeField::Custom with EXTRACT in Postgres#1394
Merged
Conversation
Pull Request Test Coverage Report for Build 10512598473Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Contributor
Author
|
I think this is good to go. |
iffyio
reviewed
Aug 22, 2024
iffyio
approved these changes
Aug 22, 2024
alamb
approved these changes
Aug 26, 2024
alamb
left a comment
Contributor
There was a problem hiding this comment.
Thank you @samuelcolvin and @iffyio
ayman-sigma
pushed a commit
to sigmacomputing/sqlparser-rs
that referenced
this pull request
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm really not a fan of this
dialect_of!stuff, it feels like I'm back writing some kind of odd Python. (I've changed this)Follows #1191.
This will allow us to match postgres syntax:
I guess all the unit names and abbreviations allowed by
INTERVALwhich I added in apache/arrow-rs#6211 are allowed, we should be able to useIntervalUnitin datafusion to process the custom value.