Skip to content

Do not allocate in impl Display for DateTimeField#1209

Merged
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/no_copy
Apr 9, 2024
Merged

Do not allocate in impl Display for DateTimeField#1209
alamb merged 1 commit into
apache:mainfrom
alamb:alamb/no_copy

Conversation

@alamb

@alamb alamb commented Apr 9, 2024

Copy link
Copy Markdown
Contributor

Follow up to #1191 from @iffyio 🙏

This avoids allocating in the Display impl of DateTimeField

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 8622424693

Details

  • 40 of 42 (95.24%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.027%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/value.rs 40 42 95.24%
Totals Coverage Status
Change from base Build 8622401139: 0.02%
Covered Lines: 21225
Relevant Lines: 24112

💛 - Coveralls

@alamb alamb merged commit a0ed14c into apache:main Apr 9, 2024
JichaoS pushed a commit to luabase/sqlparser-rs that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants