RAT-562: Use MutableInt in ClaimValidator#685
Conversation
|
@Claudenw not sure if my change changed the semantics (computeIfPresent) .... I stumbled into this change when I saw some NPE warnings within ClaimValidator. WDYT? Is the assertion that setting a max value sets a min value implicitly? Not sure if you can imagine a test that runs into the remaining NPEs or if the issue is theoretical only ;) Thanks |
|
@ottlinger please review and merge if you see fit. |
| return v; }); | ||
| min.compute(counter, (k, v) -> { | ||
| min.computeIfPresent(counter, (k, v) -> { | ||
| if (v.intValue() > maxValue.intValue()) { |
There was a problem hiding this comment.
@Claudenw the IDE marks this line as possible NPE for maxValue.intValue due to the computerIfPresent before.
ottlinger
left a comment
ottlinger
left a comment
There was a problem hiding this comment.
LGTM - thanks for fixing the possibleNPE-related things
|
2 participants
Switch to MutableInt in ClaimValidator to avoid boxing/unboxing