VPC and Virtual Network Managers refactor. Part of the VPC Redundant Router work#18

Closed

wilderrodrigues wants to merge 167 commits into

apache:masterfrom

schubergphilis:test-cmd-rebase

Commits on Sep 9, 2014

Rules and visitors for Load Balance Rules

Antonio Fornie
authored and
wilderrodrigues
committed
Adding new behaviour to the apply load balancing rules method. The whole chain has been implemented and we will now test it.
wilderrodrigues
committed
Extract general behavior to Router and Vpc delegates

Antonio Fornie
authored and
wilderrodrigues
committed
Fix dependency problem. Extract and unify router deployment stuff

Antonio Fornie
authored and
wilderrodrigues
committed
Adding Firewall Rules to comply with the Visitor pattern implementation; refactoring the applyRules so we can reuse it.

Wilder Rodrigues
authored and
wilderrodrigues
committed
changing accessor modifier in instance variables

Wilder Rodrigues
authored and
wilderrodrigues
committed
fixing checkstyles
wilderrodrigues
committed
finished firewall rules and load balancing rules; fixed all the injection problems; added VirtualMachineManager to the appliance factory to be injected.
wilderrodrigues
committed
TODO

DaanHoogland
authored and
wilderrodrigues
committed
adding static nat rules. Deploying new VMs is not working due to the appliance refactory, will check the changes with Antonio tomorrow.
wilderrodrigues
committed
we have to check if VPC is null bfore calling it. VPC is not used in gest networks, so deploying a new VM was broken.
wilderrodrigues
committed
adding apache license headers
wilderrodrigues
committed
adding Ip Association and VPN Rules
wilderrodrigues
committed
Fix offering setup

Antonio Fornie
authored and
wilderrodrigues
committed
package rename

DaanHoogland
authored and
wilderrodrigues
committed
Temporary put state info in a state object

Antonio Fornie
authored and
wilderrodrigues
committed
fixing the classes relationship; adding beans properly in the spring context; using the right basic/advance stuff; testing ip and port forwarding rules
wilderrodrigues
committed
adding password to router rules; moving the advance code to the advance net topology.
wilderrodrigues
committed
Unify and encapsulate deployment flow methods and params

Antonio Fornie
authored and
wilderrodrigues
committed
adding userdata to router and ssh pub key to router rules.
wilderrodrigues
committed
making instance variables compliant with ACS convention
wilderrodrigues
committed
adding user data pwd rules
wilderrodrigues
committed
adding DHCP entry rules
wilderrodrigues
committed
fixing injection of beans with a relationship
wilderrodrigues
committed
whitespace

DaanHoogland
authored and
wilderrodrigues
committed
fixing the injection of the networkDao
wilderrodrigues
committed
mv to better name

DaanHoogland
authored and
wilderrodrigues
committed
Deployment more OO - Objects with data and behavior

Antonio Fornie
authored and
wilderrodrigues
committed
replacing my IP by localhost to avoid problems with my environment
wilderrodrigues
committed
fixing import in virtual router element and checkstyle in dhcp entry related changes
wilderrodrigues
committed
commenting broken code in tests in order to run build adn tests other changes via the UI
wilderrodrigues
committed
removing bean from the xml
wilderrodrigues
committed
adding new bean to spring context file; renaming package from "com" to "org"
wilderrodrigues
committed
Missing dependencies are added

Antonio Fornie
authored and
wilderrodrigues
committed
Fixing null pointers during vpc router deployment

Antonio Fornie
authored and
wilderrodrigues
committed
apply network acls; acls items to pvt gw; vpc ip association
wilderrodrigues
committed
fixing VPC IP Association and ACL rules. Have to rewrite in a better why the apply rules method in the Advanced Topology
wilderrodrigues
committed
Splitting Vpc and NonVpc deployment into phases & testing it

Antonio Fornie
authored and
wilderrodrigues
committed
RouterDeployment and VPC. Improving code and Unit Testing

Antonio Fornie
authored and
wilderrodrigues
committed
rename networkMgr to networkMdl to prevent name clashes in mocks of

DaanHoogland
authored and
wilderrodrigues
committed
More refactoring and testing in the same classes

Antonio Fornie
authored and
wilderrodrigues
committed
License headers

Antonio Fornie
authored and
wilderrodrigues
committed
Replacing the old [Vpc}VirtualNetworkApplianceManager by the new ones;
wilderrodrigues
committed
Complete tests for normal deployment and start vpc one

Antonio Fornie
authored and
wilderrodrigues
committed
Factor out prepareDeployment and update tests

Antonio Fornie
authored and
wilderrodrigues
committed
Increasing test coverage for Vpc Deployment

Antonio Fornie
authored and
wilderrodrigues
committed
Fix unnecessary changes Spring contexts

Antonio Fornie
authored and
wilderrodrigues
committed
Adding VpcRouterDeploymentDefinition Unit Tests

Antonio Fornie
authored and
wilderrodrigues
committed
moving sendCommand to the NetworkGeneralHelper;
wilderrodrigues
committed
fixing check styles
wilderrodrigues
committed
Refactor to include network creation as actual deployment

Antonio Fornie
authored and
wilderrodrigues
committed
adding applyStaticRoutes method to the network topology/visitor. it will be used by the VPC virtual net manager appliance.
wilderrodrigues
committed
adding applyStaticRoutes to the new visitor pattern.
wilderrodrigues
committed
refactor VpnRules onto BasicVpnRules and AdvancedVpnRules;
wilderrodrigues
committed
DeployRouter includes nw creation following TellDontAsk principle

Antonio Fornie
authored and
wilderrodrigues
committed
Whole router.deployment package got 97% coverage

Antonio Fornie
authored and
wilderrodrigues
committed
adding setupPrivateGateway to new style;
wilderrodrigues
committed
fixing the private gateway rules in order to comply with changes in the vpc helper
wilderrodrigues
committed
fixing check style issues
wilderrodrigues
committed
Refactor and test NetworkHelper#sendCommandsToRouterWithNoAnswers

Antonio Fornie
authored and
wilderrodrigues
committed
Missing license headers

Antonio Fornie
authored and
wilderrodrigues
committed
refactor all private methods in the virtual router appliance and VPC appliance
wilderrodrigues
committed
Fix Spring collision of beans implementing NetworkHelper

Antonio Fornie
authored and
wilderrodrigues
committed
auto wire the network helper
wilderrodrigues
committed
Refactor hypervisor retrieval from VpcNwHelper and NwHelper

Antonio Fornie
authored and
wilderrodrigues
committed
Fixing NPE due to use of dependencies before Spring injection

Antonio Fornie
authored and
wilderrodrigues
committed
fix dhcp subnet rules. we can create VMs again.
wilderrodrigues
committed
fixing nic plug unplug rule
wilderrodrigues
committed
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
Fix: VpcRouter has always PublicIp setup as it did before refactoring

Antonio Fornie
authored and
wilderrodrigues
committed
making sure the instance variable _router in the Rules is being used instead of the parameter
wilderrodrigues
committed
removing the root password becuase it was breaking the simulator tests. Root password must always be empty
wilderrodrigues
committed
Removing the VirtualNetworkStatus, it was not being used properly;
wilderrodrigues
committed
Adding fixes for the add user data and vpn rules
wilderrodrigues
committed
Changing the way the DAOs were being injected in the RuleApplier;
wilderrodrigues
committed
fixing checkstyle in the virtual network manager. problem appeared after a rebase. probably due to my saving action in the eclipse workspace
wilderrodrigues
committed

Commits on Sep 10, 2014

removed unused class
Anthony Xu
committed
CLOUDSTACK-6898: [Hyper-V] fixed rdp console freezing during reboot.

anshulgangwar
authored and
devdeep
committed
CLOUDSTACK-7503: Fixed few coverity issues

anshulgangwar
authored and
devdeep
committed
CLOUDSTACK-7517: loading ftp modules in VR
Jayapal
committed
CLOUDSTACK-7519: Using bound/unbound methods instead of directly calling API methods from test case

Gaurav Aradhye
authored and
SrikanteswaraRao Talluri
committed
CLOUDSTACK-7528: More verbose logging when sending alert fails
yadvr
committed
CLOUDSTACK-7520: [UI] keep advanced search parameters visible after search has been run.

Mihaela Stoica
authored and
karuturi
committed
Added "usageid" parameter to the "listUsageRecords" API call. Can be used only together with "type" parameter specified

Ilia Shakitko
authored and
yadvr
committed
CLOUDSTACK-6099 live migration is failing for vm deployed using dynaic compute offerings with NPE

bvbharat
authored and
yadvr
committed
SAML2UserAuthenticatorTest: Fix test, make sure encoded password length > 0
yadvr
committed
CLOUDSTACK-7351: Passing hypervisor type while deploying VM using ISO

Gaurav Aradhye
authored and
SrikanteswaraRao Talluri
committed
Rules and visitors for Load Balance Rules

Antonio Fornie
authored and
wilderrodrigues
committed
Adding new behaviour to the apply load balancing rules method. The whole chain has been implemented and we will now test it.
wilderrodrigues
committed
Extract general behavior to Router and Vpc delegates

Antonio Fornie
authored and
wilderrodrigues
committed
Fix dependency problem. Extract and unify router deployment stuff

Antonio Fornie
authored and
wilderrodrigues
committed
Adding Firewall Rules to comply with the Visitor pattern implementation; refactoring the applyRules so we can reuse it.

Wilder Rodrigues
authored and
wilderrodrigues
committed
changing accessor modifier in instance variables

Wilder Rodrigues
authored and
wilderrodrigues
committed
fixing checkstyles
wilderrodrigues
committed
finished firewall rules and load balancing rules; fixed all the injection problems; added VirtualMachineManager to the appliance factory to be injected.
wilderrodrigues
committed
TODO

DaanHoogland
authored and
wilderrodrigues
committed
adding static nat rules. Deploying new VMs is not working due to the appliance refactory, will check the changes with Antonio tomorrow.
wilderrodrigues
committed
we have to check if VPC is null bfore calling it. VPC is not used in gest networks, so deploying a new VM was broken.
wilderrodrigues
committed
adding apache license headers
wilderrodrigues
committed
adding Ip Association and VPN Rules
wilderrodrigues
committed
Fix offering setup

Antonio Fornie
authored and
wilderrodrigues
committed
package rename

DaanHoogland
authored and
wilderrodrigues
committed
Temporary put state info in a state object

Antonio Fornie
authored and
wilderrodrigues
committed
fixing the classes relationship; adding beans properly in the spring context; using the right basic/advance stuff; testing ip and port forwarding rules
wilderrodrigues
committed
adding password to router rules; moving the advance code to the advance net topology.
wilderrodrigues
committed
Unify and encapsulate deployment flow methods and params

Antonio Fornie
authored and
wilderrodrigues
committed
adding userdata to router and ssh pub key to router rules.
wilderrodrigues
committed
making instance variables compliant with ACS convention
wilderrodrigues
committed
adding user data pwd rules
wilderrodrigues
committed
adding DHCP entry rules
wilderrodrigues
committed
fixing injection of beans with a relationship
wilderrodrigues
committed
whitespace

DaanHoogland
authored and
wilderrodrigues
committed
fixing the injection of the networkDao
wilderrodrigues
committed
mv to better name

DaanHoogland
authored and
wilderrodrigues
committed
Deployment more OO - Objects with data and behavior

Antonio Fornie
authored and
wilderrodrigues
committed
replacing my IP by localhost to avoid problems with my environment
wilderrodrigues
committed
fixing import in virtual router element and checkstyle in dhcp entry related changes
wilderrodrigues
committed
commenting broken code in tests in order to run build adn tests other changes via the UI
wilderrodrigues
committed
removing bean from the xml
wilderrodrigues
committed
adding new bean to spring context file; renaming package from "com" to "org"
wilderrodrigues
committed
Missing dependencies are added

Antonio Fornie
authored and
wilderrodrigues
committed
Fixing null pointers during vpc router deployment

Antonio Fornie
authored and
wilderrodrigues
committed
apply network acls; acls items to pvt gw; vpc ip association
wilderrodrigues
committed
fixing VPC IP Association and ACL rules. Have to rewrite in a better why the apply rules method in the Advanced Topology
wilderrodrigues
committed
Splitting Vpc and NonVpc deployment into phases & testing it

Antonio Fornie
authored and
wilderrodrigues
committed
RouterDeployment and VPC. Improving code and Unit Testing

Antonio Fornie
authored and
wilderrodrigues
committed
rename networkMgr to networkMdl to prevent name clashes in mocks of

DaanHoogland
authored and
wilderrodrigues
committed
More refactoring and testing in the same classes

Antonio Fornie
authored and
wilderrodrigues
committed
License headers

Antonio Fornie
authored and
wilderrodrigues
committed
Replacing the old [Vpc}VirtualNetworkApplianceManager by the new ones;
wilderrodrigues
committed
Complete tests for normal deployment and start vpc one

Antonio Fornie
authored and
wilderrodrigues
committed
Factor out prepareDeployment and update tests

Antonio Fornie
authored and
wilderrodrigues
committed
Increasing test coverage for Vpc Deployment

Antonio Fornie
authored and
wilderrodrigues
committed
Fix unnecessary changes Spring contexts

Antonio Fornie
authored and
wilderrodrigues
committed
Adding VpcRouterDeploymentDefinition Unit Tests

Antonio Fornie
authored and
wilderrodrigues
committed
moving sendCommand to the NetworkGeneralHelper;
wilderrodrigues
committed
fixing check styles
wilderrodrigues
committed
Refactor to include network creation as actual deployment

Antonio Fornie
authored and
wilderrodrigues
committed
adding applyStaticRoutes method to the network topology/visitor. it will be used by the VPC virtual net manager appliance.
wilderrodrigues
committed
adding applyStaticRoutes to the new visitor pattern.
wilderrodrigues
committed
refactor VpnRules onto BasicVpnRules and AdvancedVpnRules;
wilderrodrigues
committed
DeployRouter includes nw creation following TellDontAsk principle

Antonio Fornie
authored and
wilderrodrigues
committed
Whole router.deployment package got 97% coverage

Antonio Fornie
authored and
wilderrodrigues
committed
adding setupPrivateGateway to new style;
wilderrodrigues
committed
fixing the private gateway rules in order to comply with changes in the vpc helper
wilderrodrigues
committed
fixing check style issues
wilderrodrigues
committed
Refactor and test NetworkHelper#sendCommandsToRouterWithNoAnswers

Antonio Fornie
authored and
wilderrodrigues
committed
Missing license headers

Antonio Fornie
authored and
wilderrodrigues
committed
refactor all private methods in the virtual router appliance and VPC appliance
wilderrodrigues
committed
Fix Spring collision of beans implementing NetworkHelper

Antonio Fornie
authored and
wilderrodrigues
committed
auto wire the network helper
wilderrodrigues
committed
Refactor hypervisor retrieval from VpcNwHelper and NwHelper

Antonio Fornie
authored and
wilderrodrigues
committed
Fixing NPE due to use of dependencies before Spring injection

Antonio Fornie
authored and
wilderrodrigues
committed
fix dhcp subnet rules. we can create VMs again.
wilderrodrigues
committed
fixing nic plug unplug rule
wilderrodrigues
committed
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
merging cmd-visitor into cmd-visitor-rebase, with the upstream from ACS repo
wilderrodrigues
committed
Fix: VpcRouter has always PublicIp setup as it did before refactoring

Antonio Fornie
authored and
wilderrodrigues
committed
making sure the instance variable _router in the Rules is being used instead of the parameter
wilderrodrigues
committed
removing the root password becuase it was breaking the simulator tests. Root password must always be empty
wilderrodrigues
committed
Removing the VirtualNetworkStatus, it was not being used properly;
wilderrodrigues
committed
Adding fixes for the add user data and vpn rules
wilderrodrigues
committed
Changing the way the DAOs were being injected in the RuleApplier;
wilderrodrigues
committed
fixing checkstyle in the virtual network manager. problem appeared after a rebase. probably due to my saving action in the eclipse workspace
wilderrodrigues
committed
After an attempt to do a git pull --rebase followed by a push, I got a hint to do a pull before. So, got a merge.
wilderrodrigues
committed

Commits on Sep 11, 2014

Fixing the NetworkHelperImpl class. It was throwing a NPE due to a hypervisor type SIMULATOR not being in the hashmap.
wilderrodrigues
committed