CAMEL-23506: align aws2-sqs/sns HeaderFilterStrategy with siblings#23221
Merged
Conversation
…tegy with sibling components Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
davsclaus
approved these changes
May 14, 2026
Contributor
|
🧪 CI tested the following changed modules:
All tested modules (10 modules)
|
oscerd
added a commit
that referenced
this pull request
May 20, 2026
…23357) Sqs2HeaderFilterStrategy and Sns2HeaderFilterStrategy only configured an outbound filter. Add setInFilterStartsWith(CAMEL_FILTER_STARTS_WITH) so the inbound direction is aligned with the sibling strategies (Kafka, Mail, CoAP, Google Pub/Sub, ...). The existing outbound regex (which also catches breadcrumbId and org.apache.camel.*) is unchanged. Includes focused unit tests in both modules and the camel-4x-upgrade-guide-4_18.adoc note. (cherry picked from commit 5f57258) JIRA: https://issues.apache.org/jira/browse/CAMEL-23506 Closes #23221
oscerd
added a commit
that referenced
this pull request
May 20, 2026
…23373) Sqs2HeaderFilterStrategy and Sns2HeaderFilterStrategy only configured an outbound filter. Add setInFilterStartsWith(CAMEL_FILTER_STARTS_WITH) so the inbound direction is aligned with the sibling strategies (Kafka, Mail, CoAP, Google Pub/Sub, ...). The existing outbound regex (which also catches breadcrumbId and org.apache.camel.*) is unchanged. Includes focused unit tests in both modules and the camel-4x-upgrade-guide-4_14.adoc note. (cherry picked from commit 5f57258) JIRA: https://issues.apache.org/jira/browse/CAMEL-23506 Closes #23221
oscerd
added a commit
to apache/camel-website
that referenced
this pull request
Jul 5, 2026
CAMEL-23506 added an inbound Camel-namespace filter to Sns2HeaderFilterStrategy alongside the camel-aws2-sqs fix. camel-aws2-sns is producer-only (Sns2Endpoint.createConsumer throws UnsupportedOperationException), so there is no reachable inbound header-injection path; document this as a LOW-severity defense-in-depth hardening advisory rather than an exploitable vulnerability, cross-referencing the consumer-side camel-aws2-sqs issue CVE-2026-46456. Shares the same fix (PR apache/camel#23221, main 5f57258fb33d33ef99df10594f8fe9f11d7c2b7e, backports 7b334be0419839097a132d4ff3427fc4083e695e on camel-4.18.x and b7f78292e747a28dbf5da444265557b5f9f3c1a1 on camel-4.14.x). Also add a cross-reference sentence to CVE-2026-46456 pointing at the SNS hardening, and re-sign its .txt.asc. New advisory has a PGP-clearsigned .txt.asc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Andrea Cosentino <ancosen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sqs2HeaderFilterStrategyandSns2HeaderFilterStrategyonly configured an outbound filter. AddedsetInFilterStartsWith(CAMEL_FILTER_STARTS_WITH)so the inbound direction is aligned with the sibling strategies (Kafka, Mail, CoAP, Google Pub/Sub, …).breadcrumbIdandorg.apache.camel.*) is unchanged.Sqs2HeaderFilterStrategyTest,Sns2HeaderFilterStrategyTest.Jira: https://issues.apache.org/jira/browse/CAMEL-23506
Test plan
mvn -DskipTests installincomponents/camel-aws/camel-aws2-sqs— passesmvn -DskipTests installincomponents/camel-aws/camel-aws2-sns— passesmvn test -Dtest=Sqs2HeaderFilterStrategyTest— 4/4 passmvn test -Dtest=Sns2HeaderFilterStrategyTest— 4/4 passmvn clean install -DskipTests— passes (no stray regen artifacts)Claude Code on behalf of Andrea Cosentino