Skip to content

GH-15058: [C++][Python] Native support for UUID#37298

Merged
pitrou merged 22 commits into
apache:mainfrom
rok:15058
Aug 26, 2024
Merged

GH-15058: [C++][Python] Native support for UUID#37298
pitrou merged 22 commits into
apache:mainfrom
rok:15058

Conversation

@rok

@rok rok commented Aug 22, 2023

Copy link
Copy Markdown
Member

Rationale for this change

See #15058.
UUID datatype is common in throughout the ecosystem and Arrow as supporting it as a native type would reduce friction.

What changes are included in this PR?

This PR implements logic for Arrow canonical extension type in C++ and a Python wrapper.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes, new extension type is added.

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #15058 has been automatically assigned in GitHub to PR creator.

@mapleFU

mapleFU commented Aug 22, 2023

Copy link
Copy Markdown
Member

mentioned #15058 (comment) , do we need to remove that?

@rok rok force-pushed the 15058 branch 2 times, most recently from 184e96c to e738540 Compare August 22, 2023 10:35
@rok rok force-pushed the 15058 branch 8 times, most recently from 16329bc to a5283b6 Compare August 25, 2023 19:21
@arogozhnikov

Copy link
Copy Markdown

Key error: A type extension with name uuid already defined

Looks Ruby already got support for UUID?

@rok

rok commented Aug 26, 2024

Copy link
Copy Markdown
Member Author

Ping @jorisvandenbossche

@rok

rok commented Aug 26, 2024

Copy link
Copy Markdown
Member Author

Thanks everyone!

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 2328b6e.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 24 possible false positives for unstable benchmarks that are known to sometimes produce them.

@jorisvandenbossche

Copy link
Copy Markdown
Member

Thanks a lot @rok!

As another possible follow-up, would we want to support inferring and converting uuid.UUID objects in the python->arrow conversion layer? (although not sure if that's something people would be waiting for)

@rok

rok commented Aug 27, 2024

Copy link
Copy Markdown
Member Author

@jorisvandenbossche that sounds convenient! I've opened #43855 and will get around to it if someone else doesn't sooner :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Python] Native support for UUID

7 participants