Improve documentation and add examples for ArrowPredicateFn#7480
Merged
Conversation
phillipleblanc
approved these changes
May 9, 2025
phillipleblanc
left a comment
phillipleblanc
left a comment
Contributor
There was a problem hiding this comment.
Thanks for working on this! I happened to run into ArrowPredicateFn while working on an issue in the iceberg-rust crate, and this is helpful for understanding it.
Contributor
Author
|
Thank you for the review @phillipleblanc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
arrow_reader_clickbenchbenchmark #7470 it took me some time to work out how to use ArrowPredicateFn. I would like to make it easier for my future self. I also plan to publicize this API more over the next few months so having clear documentation is a good thingWhat changes are included in this PR?
Improve documentation and add examples for
ArrowPredicateFnAre there any user-facing changes?
Documentation only, no functional changes