Skip to content

UI: Remove unused @lezer/highlight dependency#68638

Closed
parkhojeong wants to merge 1 commit into
apache:mainfrom
parkhojeong:ui/remove-unused-lezer-highlight
Closed

UI: Remove unused @lezer/highlight dependency#68638
parkhojeong wants to merge 1 commit into
apache:mainfrom
parkhojeong:ui/remove-unused-lezer-highlight

Conversation

@parkhojeong

Copy link
Copy Markdown
Contributor

@lezer/highlight came in with the CodeMirror-based JSON editor in #43367, became a direct
dependency in #62796, and was left unused after the Monaco migration in #62708.

Validation

  • pnpm remove @lezer/highlight
  • pnpm install --frozen-lockfile
  • pnpm why @lezer/highlight
  • pnpm list @lezer/highlight --depth Infinity
  • pnpm list @lezer/common --depth Infinity
  • pnpm build
  • breeze testing ui-e2e-tests

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jun 16, 2026
@choo121600

Copy link
Copy Markdown
Member

Since #68032 is currently discussing whether Monaco Editor should be removed due to ongoing maintenance and stability concerns, I wonder if it would make sense to revisit this change after that discussion reaches a conclusion.

@parkhojeong

parkhojeong commented Jun 18, 2026

Copy link
Copy Markdown
Contributor Author

Since #68032 is currently discussing whether Monaco Editor should be removed due to ongoing maintenance and stability concerns, I wonder if it would make sense to revisit this change after that discussion reaches a conclusion.

Thanks for the context. After that discussion, this could be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants