Skip to content

Fix DAG browser tab title in React UI#67308

Closed
chocolatecake777 wants to merge 1 commit into
apache:mainfrom
chocolatecake777:paid-oss/fix-dag-browser-title
Closed

Fix DAG browser tab title in React UI#67308
chocolatecake777 wants to merge 1 commit into
apache:mainfrom
chocolatecake777:paid-oss/fix-dag-browser-title

Conversation

@chocolatecake777

Copy link
Copy Markdown

Fix DAG pages in the React UI so the browser tab title reflects the selected DAG again instead of always remaining the generic Airflow title.

closes: #67145


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

Generated-by: OpenAI Codex following the guidelines


Summary

  • Add a shared document-title hook that composes page-specific titles with the Airflow instance name.
  • Use the hook from the base layout and DAG page so DAG views update the browser tab to the DAG display name.
  • Add focused React tests covering DAG-specific document title behavior.

Verification

  • Focused Vitest command for airflow-core/src/airflow/ui/src/pages/Dag/Dag.test.tsx passed in an isolated writable rerun after the initial read-only repository mount prevented test output writes.
  • git diff --check HEAD~1 HEAD passed.
  • Final branch status is clean at 82063a39ee019210f9f8441b377a9381080192eb.

Reviewer Notes

  • The change is scoped to browser document-title handling in the React UI and does not change routing or DAG data loading behavior.

@boring-cyborg boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label May 22, 2026
@boring-cyborg

boring-cyborg Bot commented May 22, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@potiuk

potiuk commented May 24, 2026

Copy link
Copy Markdown
Member

@chocolatecake777 A few things need addressing before review — see our Pull Request quality criteria.

  • CI fails: Basic tests / React UI tests (and possibly other checks — see the Checks tab for the full list).

No rush.


Note: This comment was drafted by an AI-assisted triage tool and may contain mistakes. Once you have addressed the points above, an Apache Airflow maintainer — a real person — will take the next look at your PR. We use this two-stage triage process so that our maintainers' limited time is spent where it matters most: the conversation with you.


Drafted-by: Claude Code (Opus 4.7); reviewed by @potiuk before posting

@choo121600

Copy link
Copy Markdown
Member

@chocolatecake777 Thanks for the contribution!
This issue has already been resolved in #67169, so I'll close this PR.
We’d love to see more contributions from you in the future ;)

@choo121600 choo121600 closed this May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Browser tab title always shows "Airflow" in v3 UI — DAG name no longer reflected

3 participants