Skip to content

Change job/pod role bindings rendering & refactor related tests#66626

Merged
jscheffl merged 2 commits into
apache:mainfrom
Miretpl:simplify-and-ref-job-pod-lanucher-bind
May 9, 2026
Merged

Change job/pod role bindings rendering & refactor related tests#66626
jscheffl merged 2 commits into
apache:mainfrom
Miretpl:simplify-and-ref-job-pod-lanucher-bind

Conversation

@Miretpl

@Miretpl Miretpl commented May 9, 2026

Copy link
Copy Markdown
Contributor

Mainly simplifies the rendering logic for job and pod launcher role bindings by removing loops. Other changes are:

  1. Adding a condition on the scheduler.enabled flag for scheduler SA-related bindings
  2. Refactors job/pod/scc rolebindings-related tests for better readability

Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:helm-chart Airflow Helm Chart label May 9, 2026
@Miretpl Miretpl changed the title Simplify and ref job pod lanucher bind Change job/pod role bindings rendering & refactor related tests May 9, 2026
@Miretpl Miretpl force-pushed the simplify-and-ref-job-pod-lanucher-bind branch from 96307dd to cc6d93e Compare May 9, 2026 16:40
@Miretpl Miretpl marked this pull request as ready for review May 9, 2026 16:41
@Miretpl Miretpl force-pushed the simplify-and-ref-job-pod-lanucher-bind branch from cc6d93e to 57f6f83 Compare May 9, 2026 16:48
@Miretpl Miretpl force-pushed the simplify-and-ref-job-pod-lanucher-bind branch from 57f6f83 to 8b34fc4 Compare May 9, 2026 16:52

@jscheffl jscheffl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also 1.2x compatible, backport to maintenance branch? Or only keeping this on main?

@Miretpl

Miretpl commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

Also for 1.2x. There shouldn't be any issue with backport, but if there will be some, I will create a separate PR

@jscheffl jscheffl merged commit 00400a5 into apache:main May 9, 2026
142 checks passed
@jscheffl jscheffl added the backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch label May 9, 2026
@jscheffl jscheffl added this to the Airflow Helm Chart 1.22.0 milestone May 9, 2026
@jscheffl

jscheffl commented May 9, 2026

Copy link
Copy Markdown
Contributor

Args, setting the label too late :-(

@github-actions

github-actions Bot commented May 9, 2026

Copy link
Copy Markdown
Contributor

Backport failed to create: chart/v1-2x-test. View the failure log Run details

Note: As of Merging PRs targeted for Airflow 3.X
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.

In matter of doubt please ask in #release-management Slack channel.

Status Branch Result
chart/v1-2x-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 00400a5 chart/v1-2x-test

This should apply the commit to the chart/v1-2x-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@jscheffl

jscheffl commented May 9, 2026

Copy link
Copy Markdown
Contributor

@Miretpl Can you back-port?

Miretpl added a commit to Miretpl/airflow that referenced this pull request May 9, 2026
…he#66626)

* Simplify job/pod launcher role binding templates

* Refactor tests & render scheduler when enabled

(cherry picked from commit 00400a5)
Miretpl added a commit to Miretpl/airflow that referenced this pull request May 9, 2026
…he#66626)

* Simplify job/pod launcher role binding templates

* Refactor tests & render scheduler when enabled

(cherry picked from commit 00400a5)
@Miretpl

Miretpl commented May 9, 2026

Copy link
Copy Markdown
Contributor Author

@jscheffl backport ready #66634

@Miretpl Miretpl deleted the simplify-and-ref-job-pod-lanucher-bind branch May 9, 2026 20:02
jscheffl pushed a commit that referenced this pull request May 9, 2026
…) (#66634)

* Simplify job/pod launcher role binding templates

* Refactor tests & render scheduler when enabled

(cherry picked from commit 00400a5)
jason810496 pushed a commit to jason810496/airflow that referenced this pull request May 11, 2026
…he#66626)

* Simplify job/pod launcher role binding templates

* Refactor tests & render scheduler when enabled
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:helm-chart Airflow Helm Chart backport-to-chart/v1-2x-test Automatic backport to chart 1.2x maintenance branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants