Change job/pod role bindings rendering & refactor related tests#66626
Conversation
96307dd to
cc6d93e
Compare
cc6d93e to
57f6f83
Compare
57f6f83 to
8b34fc4
Compare
jscheffl
left a comment
There was a problem hiding this comment.
This is also 1.2x compatible, backport to maintenance branch? Or only keeping this on main?
|
Also for 1.2x. There shouldn't be any issue with backport, but if there will be some, I will create a separate PR |
|
Args, setting the label too late :-( |
Backport failed to create: chart/v1-2x-test. View the failure log Run detailsNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
You can attempt to backport this manually by running: cherry_picker 00400a5 chart/v1-2x-testThis should apply the commit to the chart/v1-2x-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continueIf you don't have cherry-picker installed, see the installation guide. |
|
@Miretpl Can you back-port? |
…he#66626) * Simplify job/pod launcher role binding templates * Refactor tests & render scheduler when enabled
Mainly simplifies the rendering logic for job and pod launcher role bindings by removing loops. Other changes are:
scheduler.enabledflag for scheduler SA-related bindingsWas generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.