[chart/v1-2x-test] Add optional OTel service to the Airflow Helm Chart (#64902)#66465
Merged
jscheffl merged 1 commit intoMay 7, 2026
Merged
Conversation
Contributor
Author
Miretpl
approved these changes
May 6, 2026
jscheffl
approved these changes
May 6, 2026
Contributor
|
Oh, CI is not (correctly) configured for the maintenance branch, so ran tests manually. Unfortunaltely helm tests fail:
|
* add otel to helm chart * use Kustomize for grafana, jaeger, prometheus * enable specific service per flag + unit test * remove grafana, jaeger and prometheus kustomization logic * traces enabled and metrics disabled, by default * remove otelCollector.enabled flag * add statsd comments about otel metrics overriding the config * make OTEL_METRIC_EXPORT_INTERVAL configurable and provide default value + entry in the values.schema.json * remove hardcoded value for metrics otel_port in values.yaml * add option to override the configmap * add otelCollector.args and make the config.yml file as the default argument * rename extraAnnotations to annotations in otel-collector-service.yaml * parameterize the readiness and liveness probe values * remove prometheus from the configmap * update the default value for OTEL_TRACES_EXPORTER * fix tests in airflow_aux + otel-collector-serviceaccount.yaml * fix spellcheck errors in docs * fix tests in security * otel collector unit tests + networkpolicy file * values.schema.json cleanup * add a minimum to all integer configs in values.schema.json * fix heading comments * change config default to ~ from empty string * fix static check error
b2630a0 to
a2cea95
Compare
Contributor
Author
|
@jscheffl Can you check again? It should have been fixed now. |
Contributor
Thanks! Tests pass now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport because of conflicts.
I tested it manually and everything still works.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.