Fix database cleanup lifecycle hooks#65881
Merged
jscheffl merged 1 commit intoApr 26, 2026
Merged
Conversation
henry3260
requested review from
bugraoz93,
dstandish,
hussein-awala,
jedcunningham and
jscheffl
as code owners
jscheffl
added
the
backport-to-chart/v1-2x-test
jscheffl
approved these changes
Apr 26, 2026
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thanks for the fix in consistency!
Contributor
Backport successfully created: chart/v1-2x-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
jscheffl
pushed a commit
that referenced
this pull request
Apr 26, 2026
There was a problem hiding this comment.
Is it good to add one default-case test to assert that lifecycle is not rendered when neither databaseCleanup.containerLifecycleHooks nor global containerLifecycleHooks is set?
29 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The chart already exposes
databaseCleanup.containerLifecycleHooksin values.yaml, but the cleanup CronJob template never used that value. In practice, this means users can configure the option but it has no effect.This change fixes that mismatch between chart values and template behavior.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.