fix(connection-model): RFC3896 conn_type warning (#63167)#65294
Merged
Conversation
* fix(connection): check pre-normalized conn_type when warning about presence of underscores in conn_type * feat(connection): added test_get_uri_conn_type_warning method to TestConnection * fix(connection): use conn_type attr as default value when checking conn_type for presence of underscores in get_uri * fix(connection): generalized test cases used by test_get_uri_conn_type_warning test to include connections instantiated using a URI and connections instantiated not using a URI * fix(connection): coalesce conn_type value to an empty string before checking for presence of underscores in conn_type in get_uri * refactor(connection): updated assertion messages in test_get_uri_conn_type_warning method * style(connection): formatting changes according to prek static checks (cherry picked from commit 06c75db)
vatsrahul1001
requested review from
Lee-W,
hussein-awala and
potiuk
and removed request for
XD-DENG and
ashb
Lee-W
approved these changes
Apr 15, 2026
vatsrahul1001
added
the
changelog:skip
vatsrahul1001
added a commit
that referenced
this pull request
Apr 15, 2026
* fix(connection): check pre-normalized conn_type when warning about presence of underscores in conn_type * feat(connection): added test_get_uri_conn_type_warning method to TestConnection * fix(connection): use conn_type attr as default value when checking conn_type for presence of underscores in get_uri * fix(connection): generalized test cases used by test_get_uri_conn_type_warning test to include connections instantiated using a URI and connections instantiated not using a URI * fix(connection): coalesce conn_type value to an empty string before checking for presence of underscores in conn_type in get_uri * refactor(connection): updated assertion messages in test_get_uri_conn_type_warning method * style(connection): formatting changes according to prek static checks (cherry picked from commit 06c75db) Co-authored-by: Michael Trossbach <mptrossbach@gmail.com>
vatsrahul1001
added a commit
that referenced
this pull request
Apr 15, 2026
* fix(connection): check pre-normalized conn_type when warning about presence of underscores in conn_type * feat(connection): added test_get_uri_conn_type_warning method to TestConnection * fix(connection): use conn_type attr as default value when checking conn_type for presence of underscores in get_uri * fix(connection): generalized test cases used by test_get_uri_conn_type_warning test to include connections instantiated using a URI and connections instantiated not using a URI * fix(connection): coalesce conn_type value to an empty string before checking for presence of underscores in conn_type in get_uri * refactor(connection): updated assertion messages in test_get_uri_conn_type_warning method * style(connection): formatting changes according to prek static checks (cherry picked from commit 06c75db) Co-authored-by: Michael Trossbach <mptrossbach@gmail.com>
vatsrahul1001
added a commit
that referenced
this pull request
Apr 15, 2026
* fix(connection): check pre-normalized conn_type when warning about presence of underscores in conn_type * feat(connection): added test_get_uri_conn_type_warning method to TestConnection * fix(connection): use conn_type attr as default value when checking conn_type for presence of underscores in get_uri * fix(connection): generalized test cases used by test_get_uri_conn_type_warning test to include connections instantiated using a URI and connections instantiated not using a URI * fix(connection): coalesce conn_type value to an empty string before checking for presence of underscores in conn_type in get_uri * refactor(connection): updated assertion messages in test_get_uri_conn_type_warning method * style(connection): formatting changes according to prek static checks (cherry picked from commit 06c75db) Co-authored-by: Michael Trossbach <mptrossbach@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #63167
(cherry picked from commit 06c75db)
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.