Fix serializer for empty string extra connection#65014
Merged
pierrejeambrun merged 2 commits intoApr 14, 2026
Merged
Conversation
pierrejeambrun
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
jason810496,
rawwar and
shubhamraj-git
as code owners
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FastAPI response serialization for Connections whose extra value is persisted as an empty string (""), preserving backward compatibility and preventing a 500 error in the connections endpoint (regression for #64950).
Changes:
- Adjust
ConnectionResponse.redact_extrato treat""as a valid no-op value (skip JSON parsing/redaction). - Add a regression test covering
extrabeingNULLor""on the GET connection endpoint.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py |
Prevents JSON parsing/serialization errors by accepting empty-string extra in the response validator. |
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_connections.py |
Adds coverage ensuring GET /connections/{id} returns 200 when extra is NULL or "". |
…ctions.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vatsrahul1001
approved these changes
Apr 14, 2026
choo121600
approved these changes
Apr 14, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
Apr 14, 2026
* Fix serializer for empty string extra connection * Update airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- (cherry picked from commit 41bd4cd) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
Backport successfully created: v3-2-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
pierrejeambrun
added a commit
that referenced
this pull request
Apr 14, 2026
…#65215) * Fix serializer for empty string extra connection * Update airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py --------- (cherry picked from commit 41bd4cd) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…#65215) * Fix serializer for empty string extra connection * Update airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py --------- (cherry picked from commit 41bd4cd) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…#65215) * Fix serializer for empty string extra connection * Update airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py --------- (cherry picked from commit 41bd4cd) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…#65215) * Fix serializer for empty string extra connection * Update airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py --------- (cherry picked from commit 41bd4cd) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
vatsrahul1001
pushed a commit
that referenced
this pull request
Apr 15, 2026
…#65215) * Fix serializer for empty string extra connection * Update airflow-core/src/airflow/api_fastapi/core_api/datamodels/connections.py --------- (cherry picked from commit 41bd4cd) Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #64950
For backward compatibility reasons (since AF2 I believe, empty string
""is still supported as a valid value for extra field in connection)Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.