Fix XCom migration failing for NaN/Infinity float values (#62686)#62760
Merged
jedcunningham merged 1 commit intoMar 3, 2026
Merged
Conversation
XCom values containing float('nan'), float('inf'), or float('-inf')
caused the database migration to silently corrupt data or fail
outright when upgrading. Three bugs were present across backends:
- Consecutive tokens (e.g. [NaN, NaN]) were only partially replaced,
leaving bare NaN/Infinity in the output and breaking the JSON cast.
- Infinity and -Infinity were not handled at all — only NaN was.
- Bare top-level values (a single NaN or Infinity, not inside a list
or dict) were not matched and passed through unconverted.
MySQL also had two bugs in the replacement query that caused it to produce
the wrong output (one of these was pre-existing from apache#57866).
Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
(cherry picked from commit 7a301e6)
boring-cyborg
Bot
added
area:db-migrations
vatsrahul1001
approved these changes
Mar 3, 2026
vatsrahul1001
added a commit
that referenced
this pull request
Mar 4, 2026
…2760) XCom values containing float('nan'), float('inf'), or float('-inf') caused the database migration to silently corrupt data or fail outright when upgrading. Three bugs were present across backends: - Consecutive tokens (e.g. [NaN, NaN]) were only partially replaced, leaving bare NaN/Infinity in the output and breaking the JSON cast. - Infinity and -Infinity were not handled at all — only NaN was. - Bare top-level values (a single NaN or Infinity, not inside a list or dict) were not matched and passed through unconverted. MySQL also had two bugs in the replacement query that caused it to produce the wrong output (one of these was pre-existing from #57866). (cherry picked from commit 7a301e6) Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
81 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XCom values containing float('nan'), float('inf'), or float('-inf') caused the database migration to silently corrupt data or fail outright when upgrading. Three bugs were present across backends:
MySQL also had two bugs in the replacement query that caused it to produce the wrong output (one of these was pre-existing from #57866).
Backport of #62686
(cherry picked from commit 7a301e6)