Skip to content

Clean up stale Python 3.9 workaround in airflow-ctl CLI config parser#62206

Merged
bugraoz93 merged 2 commits into
apache:mainfrom
haseebmalik18:fix/cleanup-python39-todo-cli-config
Feb 26, 2026
Merged

Clean up stale Python 3.9 workaround in airflow-ctl CLI config parser#62206
bugraoz93 merged 2 commits into
apache:mainfrom
haseebmalik18:fix/cleanup-python39-todo-cli-config

Conversation

@haseebmalik18

Copy link
Copy Markdown
Contributor

The airflow-ctl CLI config parser had a workaround for Python 3.9 that used string splitting (split("|")) to parse union return type annotations.

Now that Python 3.9 is no longer supported, this replaces it with a _union_members() helper that walks the AST directly using ast.BinOp (|) nodes instead.

@bugraoz93

bugraoz93 commented Feb 20, 2026

Copy link
Copy Markdown
Contributor

Thanks for the PR! We are going to release a new version today. This will be included in the next release, so I will review it in the coming days. Let's see the integration tests. Added tag to fully test

@bugraoz93 bugraoz93 added the full tests needed We need to run full set of tests for this PR to merge label Feb 20, 2026
@bugraoz93 bugraoz93 closed this Feb 20, 2026
@bugraoz93 bugraoz93 reopened this Feb 20, 2026
@haseebmalik18

Copy link
Copy Markdown
Contributor Author

Thanks for the PR! We are going to release a new version today. This will be included in the next release, so I will review it in the coming days. Let's see the integration tests. Added tag to fully test

Sounds good!

@haseebmalik18

Copy link
Copy Markdown
Contributor Author

@bugraoz93 Hey, any update on this?

@bugraoz93 bugraoz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :) Thanks for the PR!

@haseebmalik18

Copy link
Copy Markdown
Contributor Author

@bugraoz93 Will this be merged in the next release?

@bugraoz93

Copy link
Copy Markdown
Contributor

No, just taking time for others to check too, we can merge soon

@bugraoz93

Copy link
Copy Markdown
Contributor

It will be released in the next cycle that's true, that doesn't mean we won't merge it

@bugraoz93 bugraoz93 merged commit 6a21460 into apache:main Feb 26, 2026
207 checks passed
AkshayArali pushed a commit to AkshayArali/airflow_630 that referenced this pull request Feb 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:airflow-ctl full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants