Skip to content

Optimize task_reschedule_count query with EXISTS check #62062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
manipatnam wants to merge 2 commits into from
Closed

Optimize task_reschedule_count query with EXISTS check #62062

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40cea5e
Optimize task_reschedule_count query with EXISTS check
manipatnam Feb 17, 2026
04b936d
Merge branch 'main' into optimize-reschedule-count-query
manipatnam Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions airflow-core/src/airflow/api_fastapi/execution_api/routes/task_instances.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
from cadwyn import VersionedAPIRouter
from fastapi import Body, HTTPException, Query, status
from pydantic import JsonValue
from sqlalchemy import func, or_, tuple_, update
from sqlalchemy import exists, func, or_, tuple_, update
from sqlalchemy.engine import CursorResult
from sqlalchemy.exc import NoResultFound, SQLAlchemyError
from sqlalchemy.orm import joinedload
Expand Down Expand Up @@ -241,12 +241,18 @@ def ti_run(
xcom_query = xcom_query.where(XComModel.map_index == map_index)

xcom_keys = list(session.scalars(xcom_query))
task_reschedule_count = (
session.scalar(
select(func.count(TaskReschedule.id)).where(TaskReschedule.ti_id == task_instance_id)

has_reschedules = session.scalar(select(exists().where(TaskReschedule.ti_id == task_instance_id)))

if has_reschedules:
task_reschedule_count = (
session.scalar(
select(func.count(TaskReschedule.id)).where(TaskReschedule.ti_id == task_instance_id)
)
or 0

@ephraimbuddy ephraimbuddy Feb 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This amounts to double queries. I think the right fix is adding index on the id which was done here: #61983

)
or 0
)
else:
task_reschedule_count = 0

context = TIRunContext(
dag_run=dr,
Expand Down
Loading