[v3-1-test] Fix slots negative infinity (#61140)#61768
Merged
Merged
Conversation
1 task
jason810496
approved these changes
Feb 13, 2026
* added deprecation of project_id parameter mentioned about deprication of project_id parameter * Fix Pool API to support unlimited slots -1/infinity * removed bigquery.rst * fixed when return inf for json comaptibility * removed infinity and make sured that only pool slots >=-1(-1 for infinity) * some reformatting * in test_post_pool_rejects_infinity_string to post to pools * pools use -1 as unlimited slots * Revert "pools use -1 as unlimited slots" This reverts commit 99f8681. * Fix CI --------- (cherry picked from commit 1ceb7ed) Co-authored-by: kamran Imaz <136354689+KamranImaaz@users.noreply.github.com> Co-authored-by: kamran imaz <136354689+Kamran-imaz@users.noreply.github.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
167e8f6 to
f18a6ba
Compare
pierrejeambrun
approved these changes
Feb 16, 2026
vatsrahul1001
pushed a commit
that referenced
this pull request
Mar 4, 2026
* [v3-1-test] Fix slots negative infinity (#61140) * added deprecation of project_id parameter mentioned about deprication of project_id parameter * Fix Pool API to support unlimited slots -1/infinity * removed bigquery.rst * fixed when return inf for json comaptibility * removed infinity and make sured that only pool slots >=-1(-1 for infinity) * some reformatting * in test_post_pool_rejects_infinity_string to post to pools * pools use -1 as unlimited slots * Revert "pools use -1 as unlimited slots" This reverts commit 99f8681. * Fix CI --------- (cherry picked from commit 1ceb7ed) Co-authored-by: kamran Imaz <136354689+KamranImaaz@users.noreply.github.com> Co-authored-by: kamran imaz <136354689+Kamran-imaz@users.noreply.github.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com> * Fix CI --------- Co-authored-by: kamran Imaz <136354689+KamranImaaz@users.noreply.github.com> Co-authored-by: kamran imaz <136354689+Kamran-imaz@users.noreply.github.com> Co-authored-by: pierrejeambrun <pierrejbrun@gmail.com>
81 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mentioned about deprication of project_id parameter
Fix Pool API to support unlimited slots -1/infinity
removed bigquery.rst
fixed when return inf for json comaptibility
removed infinity and make sured that only pool slots >=-1(-1 for infinity)
some reformatting
in test_post_pool_rejects_infinity_string to post to pools
pools use -1 as unlimited slots
Revert "pools use -1 as unlimited slots"
This reverts commit 99f8681.
(cherry picked from commit 1ceb7ed)
Co-authored-by: kamran Imaz 136354689+KamranImaaz@users.noreply.github.com
Co-authored-by: kamran imaz 136354689+Kamran-imaz@users.noreply.github.com
Co-authored-by: pierrejeambrun pierrejbrun@gmail.com