Skip to content

Fix infinite password retry loop in airflowctl EncryptedKeyring initialization#61329

Merged
dheerajturaga merged 1 commit into
apache:mainfrom
dheerajturaga:bugfix/airflowctl-infinite-password-retry
Feb 1, 2026
Merged

Fix infinite password retry loop in airflowctl EncryptedKeyring initialization#61329
dheerajturaga merged 1 commit into
apache:mainfrom
dheerajturaga:bugfix/airflowctl-infinite-password-retry

Conversation

@dheerajturaga

@dheerajturaga dheerajturaga commented Feb 1, 2026

Copy link
Copy Markdown
Member

The upstream keyrings.alt EncryptedKeyring prompts for a new keyring
password in an unbounded while-True loop when the keyring file does not
yet exist. The active backend is typically a ChainerBackend that wraps
EncryptedKeyring as a child, so the patch walks into .backends to find
and replace _get_new_password before keyring.set_password() can trigger
initialization. Raises AirflowCtlKeyringException after 3 attempts.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)
    ClaudeCode

…alization

  The upstream keyrings.alt EncryptedKeyring prompts for a new keyring
  password in an unbounded while-True loop when the keyring file does not
  yet exist.  The active backend is typically a ChainerBackend that wraps
  EncryptedKeyring as a child, so the patch walks into .backends to find
  and replace _get_new_password before keyring.set_password() can trigger
  initialization.  Raises AirflowCtlKeyringException after 3 attempts.

@bugraoz93 bugraoz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good one!

@dheerajturaga dheerajturaga merged commit af12a42 into apache:main Feb 1, 2026
82 checks passed
@dheerajturaga dheerajturaga deleted the bugfix/airflowctl-infinite-password-retry branch February 1, 2026 19:23
shashbha14 pushed a commit to shashbha14/airflow that referenced this pull request Feb 2, 2026
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Ratasa143 pushed a commit to Ratasa143/airflow that referenced this pull request Feb 15, 2026
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants