Skip to content

Persist DataTable column visibility using useLocalStorage #61280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sanchalitorpe13 wants to merge 1 commit into from
Closed

Persist DataTable column visibility using useLocalStorage #61280

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions airflow-core/src/airflow/ui/src/components/DataTable/DataTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
* specific language governing permissions and limitations
* under the License.
*/

import { useLocalStorage } from 'src/utils/useLocalStorage';

@pierrejeambrun pierrejeambrun Feb 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't exists. Import path is wrong.

@guan404ming guan404ming Feb 6, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The correct one is

import { useLocalStorage } from "usehooks-ts";

import { Heading, HStack, Text } from "@chakra-ui/react";
import {
getCoreRowModel,
Expand Down Expand Up @@ -109,9 +111,11 @@ export const DataTable = <TData,>({
[onStateChange],
);

const [columnVisibility, setColumnVisibility] = useState<VisibilityState>(
initialState?.columnVisibility ?? {},
);
const [columnVisibility, setColumnVisibility] = useLocalStorage<VisibilityState>(
'datatable:${modelName}:columnVisibility',

@pierrejeambrun pierrejeambrun Feb 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't work like this, you are not doing interpolation.

Suggested change
'datatable:${modelName}:columnVisibility',
`dataTable:${modelName}:columnVisibility`,

initialState?.columnVisibility ?? {},
);


const rest = Boolean(isLoading) ? createSkeletonMock(displayMode, skeletonCount, columns) : {};

Expand Down
Loading