Skip to content

Refactor datamodel defaulting logic into dedicated method#61236

Merged
dheerajturaga merged 1 commit into
apache:mainfrom
dheerajturaga:refactor/fix-ctl-cyclomatic
Feb 3, 2026
Merged

Refactor datamodel defaulting logic into dedicated method#61236
dheerajturaga merged 1 commit into
apache:mainfrom
dheerajturaga:refactor/fix-ctl-cyclomatic

Conversation

@dheerajturaga

Copy link
Copy Markdown
Member

Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
a new _apply_datamodel_defaults method. This addresses review feedback to
reduce cyclomatic complexity in the already-complex _get_func method and
provides a centralized location for managing datamodel-specific defaults.

Follow up from: #61047

  Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.

@bugraoz93 bugraoz93 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat!

@dheerajturaga dheerajturaga merged commit 47a4f1a into apache:main Feb 3, 2026
81 checks passed
@dheerajturaga dheerajturaga deleted the refactor/fix-ctl-cyclomatic branch February 3, 2026 03:02
jason810496 pushed a commit to abhijeets25012-tech/airflow that referenced this pull request Feb 3, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
Alok-kumar-priyadarshi pushed a commit to Alok-kumar-priyadarshi/airflow that referenced this pull request Feb 5, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
Ratasa143 pushed a commit to Ratasa143/airflow that referenced this pull request Feb 15, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
radhwene pushed a commit to radhwene/airflow that referenced this pull request Mar 21, 2026
Extract TriggerDAGRunPostBody logical_date defaulting from _get_func into
  a new _apply_datamodel_defaults method. This addresses review feedback to
  reduce cyclomatic complexity in the already-complex _get_func method and
  provides a centralized location for managing datamodel-specific defaults.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants