Migrate redis provider to common.compat#57006
Merged
Merged
Conversation
13 tasks
Member
|
Compat failing on missing next_dagrun_info ? |
jason810496
reviewed
Oct 22, 2025
jason810496
left a comment
Member
There was a problem hiding this comment.
Compat failing on missing next_dagrun_info ?
Yes, since after the change we will import airflow.sdk.DAG for AIRFLOW_V_3_0_PLUS, but we need to import airflow.models.DAG to make the following Dag setup works.
So maybe we could rewrite the test to just setup the TI instead of the whole Dag like TestGCSTaskHandler one:
Member
|
I can help out rewrite the test tomorrow if this is not very urgent |
Replace version-specific conditional imports with common.compat layer. This standardizes compatibility handling across Airflow 2.x and 3.x.
a3ea4e0 to
36a0de7
Compare
Member
Author
|
This works. Failure is unrelated -- its a transient mongo error |
eladkal
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace version-specific conditional imports with common.compat layer. This standardizes compatibility handling across Airflow 2.x and 3.x.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.