Potential fix for code scanning alert no. 519: Clear-text logging of sensitive information#54742
Merged
Merged
Conversation
…sensitive information Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
eladkal
approved these changes
Aug 20, 2025
Contributor
Backport successfully created: v3-0-test
|
Member
Author
|
no need to backport |
mangal-vairalkar
pushed a commit
to mangal-vairalkar/airflow
that referenced
this pull request
Aug 30, 2025
…sensitive information (apache#54742) Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/apache/airflow/security/code-scanning/519
To fix the problem, we should avoid logging the OAuth token in clear text. Instead, we can log that a token was retrieved, without including its value. If necessary for debugging, we could log only non-sensitive metadata (such as the type or length of the token), or redact the token value (e.g., log only the first few characters, or a hash). The best fix is to remove the token value from the log message entirely, replacing it with a generic message indicating that the token was accessed. This change should be made in the
oauth_token_getterstatic method, specifically on line 2196. No new imports or definitions are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.