Skip to content

Convert auth manager into cachable flag and configure it for more commands#54325

Merged
potiuk merged 1 commit into
apache:mainfrom
potiuk:turn-auth-manager-in-cacheable-flag
Aug 10, 2025
Merged

Convert auth manager into cachable flag and configure it for more commands#54325
potiuk merged 1 commit into
apache:mainfrom
potiuk:turn-auth-manager-in-cacheable-flag

Conversation

@potiuk

@potiuk potiuk commented Aug 10, 2025

Copy link
Copy Markdown
Member

The --auth-manager was only defined for "start-airflow" command so far, and you had to use it every time you wanted to swith to non-default Auth Manager (FabAuthManager). This was not very convenient when you wanted to test things with breeze shell and keep it configured between sessions.

After this change:

  • turns --auth-manager into "CacheableChoice" flag - where last used value is cached in .build folder and reused next time automatically

  • the flag is now present in those commands:

    • start-airflow
    • breeze shell
    • breeze
  • You can configure auth manager and change the cached value via breeze setup config command - like python/backend etc.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

…mands

The `--auth-manager` was only defined for "start-airflow" command so far,
and you had to use it every time you wanted to swith to non-default Auth Manager
(FabAuthManager). This was not very convenient when you wanted to test things
with breeze shell and keep it configured between sessions.

After this change:

* turns --auth-manager into "CacheableChoice" flag - where last used
  value is cached in .build folder and reused next time automatically

* the flag is now present in those commands:

  * start-airflow
  * breeze shell
  * breeze

* You can configure auth manager and change the cached value via
  `breeze setup config` command - like python/backend etc.
@potiuk

potiuk commented Aug 10, 2025

Copy link
Copy Markdown
Member Author

Query last cached value:

Screenshot 2025-08-10 at 20 29 38

You can set it with setup config

Screenshot 2025-08-10 at 20 30 10

Every time you use it in other commands, last value is cached:

Screenshot 2025-08-10 at 20 31 42

@aritra24 aritra24 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a once over, lgtm

@gopidesupavan gopidesupavan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice :)

@potiuk
potiuk merged commit 2770924 into apache:main Aug 10, 2025
107 checks passed
@potiuk
potiuk deleted the turn-auth-manager-in-cacheable-flag branch August 10, 2025 20:14
@github-actions

Copy link
Copy Markdown
Contributor

Backport failed to create: v3-0-test. View the failure log Run details

Status Branch Result
v3-0-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 2770924 v3-0-test

This should apply the commit to the v3-0-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

potiuk added a commit to potiuk/airflow that referenced this pull request Aug 10, 2025
…mands (apache#54325)

The `--auth-manager` was only defined for "start-airflow" command so far,
and you had to use it every time you wanted to swith to non-default Auth Manager
(FabAuthManager). This was not very convenient when you wanted to test things
with breeze shell and keep it configured between sessions.

After this change:

* turns --auth-manager into "CacheableChoice" flag - where last used
  value is cached in .build folder and reused next time automatically

* the flag is now present in those commands:

  * start-airflow
  * breeze shell
  * breeze

* You can configure auth manager and change the cached value via
  `breeze setup config` command - like python/backend etc.

(cherry picked from commit 2770924)
potiuk added a commit that referenced this pull request Aug 10, 2025
…mands (#54325) (#54330)

The `--auth-manager` was only defined for "start-airflow" command so far,
and you had to use it every time you wanted to swith to non-default Auth Manager
(FabAuthManager). This was not very convenient when you wanted to test things
with breeze shell and keep it configured between sessions.

After this change:

* turns --auth-manager into "CacheableChoice" flag - where last used
  value is cached in .build folder and reused next time automatically

* the flag is now present in those commands:

  * start-airflow
  * breeze shell
  * breeze

* You can configure auth manager and change the cached value via
  `breeze setup config` command - like python/backend etc.

(cherry picked from commit 2770924)
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Aug 15, 2025
…mands (apache#54325)

The `--auth-manager` was only defined for "start-airflow" command so far,
and you had to use it every time you wanted to swith to non-default Auth Manager
(FabAuthManager). This was not very convenient when you wanted to test things
with breeze shell and keep it configured between sessions.

After this change:

* turns --auth-manager into "CacheableChoice" flag - where last used
  value is cached in .build folder and reused next time automatically

* the flag is now present in those commands:

  * start-airflow
  * breeze shell
  * breeze

* You can configure auth manager and change the cached value via
  `breeze setup config` command - like python/backend etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants