Fix migration when xcom has NaN values#53812
Conversation
|
I wonder if it’s better to delete those rows instead. XCom is not designed as a long term storage. Also, what happens if a new ti tries to push invalid values in 3.x? |
…w into fix-nan-xcom-migration
I prefer this too |
As per the discussion with @uranusjr, we can serialize nan to string |
amoghrajesh
left a comment
There was a problem hiding this comment.
@vatsrahul1001 thanks, I think the fix would work as it achieves json compliancy and doesn't change the type too.
Backport failed to create: v3-0-test. View the failure log Run details
You can attempt to backport this manually by running: cherry_picker dee3a61 v3-0-testThis should apply the commit to the v3-0-test branch and leave the commit in conflict state marking After you have resolved the conflicts, you can continue the backport process by running: cherry_picker --continue |
closes: #51178
Testing:
[{"day": "2024-06-07", "ArticleCountMetric": NaN}][{"day": "2024-06-07", "ArticleCountMetric": "nan"}]^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.