Conversation
The error branch interpolated toolResult.content directly, so MCP error
payloads shaped as [{ type: "text", text: "..." }] stringified to
[object Object]. Reuse the same text extraction path as successful
results via normalizeToolResultText.
Fixes anthropics#1841
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix step summary rendering for failed MCP tool calls whose
contentis a text-block array.Motivation
Fixes #1841. MCP servers (including this action's own MCP server) return tool errors as
[{ type: "text", text: "..." }]. The error branch interpolatedtoolResult.contentdirectly, which stringified to[object Object]. The success path already handled this shape viaformatResultContent.Changes
extractToolResultTextandnormalizeToolResultTexthelpers fromformatResultContentnormalizeToolResultTextin the error branch so MCP text blocks render as plain error textTests
bun test test/format-turns.test.ts— 47 passedbun run typecheck— passedNotes
Error messages now also receive the same secret redaction and 3000-char truncation as successful tool results.