fix: reuse current location for directory browsing - #46970
Merged
Conversation
opencode-agent
Bot
requested review from
Brendonovich and
Hona
as code owners
September 3, 2026 03:35
The picker now sends absolute listing paths, so the old empty-path-only mock returned no directories. Browse the real parent and return the project entry relative to the unchanged Location; assert that browsing keeps that Location and selects the exact project.
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Directory completion and the project picker used each directory being browsed as a new Location. The first request to each one booted its complete runtime, including inherited MCP servers.
Keep the existing filesystem endpoint and browse through one stable Location instead:
fs.list({ location, path })to accept absolute paths or paths relative to the Location, including parents and siblings outside its cwd. Returned entries stay relative to that Location, including./when listing the cwd from its parent./cdcompletion and app picker navigation, preloading, and suggestions. Only committed navigation changes the selected Location.No new endpoint, host-global filesystem fallback, or MCP lifecycle redesign.
Fixes #46826.
Validation
~filenames.bun run generate; the Effect client's list path now accepts a plain string rather than requiring aRelativePathbrand. Formatting and diff checks passed./workspace/currentacross five listings.Boundaries and follow-up
Path already exists: "sibling/nested/"tree-expansion error was reproduced on both the base and this branch. The navigation assertion passes here, but that separate preload/application defect remains unchanged.Requested by: @thdxr (dax via Slack)