Replaced the NotImplementedException from ToUnit with UnitNotFoundException#1594
Merged
Merged
Conversation
- replaced the NotImplementedException which is thrown from the ToUnit method with UnitNotFoundException
Collaborator
Author
|
@angularsen Well, technically this would be a breaking change for someone who's actually catching for the |
Collaborator
Author
PS There are some tests coming for it in #1587 (currently |
lipchev
changed the title
Owner
|
@lipchev Reminder to unskip the tests you mentioned in #1594 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NotImplementedExceptionwhich is thrown from theToUnitmethod withUnitNotFoundException