Skip to content

Deprecating the Multiply/Divide methods for the Temperature#1589

Merged
angularsen merged 1 commit into
angularsen:maintenance/v5from
lipchev:deprecate-temperature-methods
Aug 2, 2025
Merged

Deprecating the Multiply/Divide methods for the Temperature#1589
angularsen merged 1 commit into
angularsen:maintenance/v5from
lipchev:deprecate-temperature-methods

Conversation

@lipchev

@lipchev lipchev commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator

As discussed in #1587, these are supposed to go away in v6

@lipchev

lipchev commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator Author

@angularsen Should I also try to deal with the Equals method? It's part of the generated code, and if we were to introduce the overload (with TemperatureDelta as tolerance), we'd have to probably also handle it in the very generic overload..

@angularsen

Copy link
Copy Markdown
Owner

@angularsen Should I also try to deal with the Equals method? It's part of the generated code, and if we were to introduce the overload (with TemperatureDelta as tolerance), we'd have to probably also handle it in the very generic overload..

I don't have a good overview, but if you see a good way to obsolete equals methods in v5 where better overloads already exist in v5 and not only introduced in v6, then sure.

@angularsen angularsen merged commit 4b86df5 into angularsen:maintenance/v5 Aug 2, 2025
1 check passed
@angularsen

Copy link
Copy Markdown
Owner

I'll just merge this regardless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants