Update with english - #38
Merged
Merged
Conversation
amisadmin
approved these changes
Mar 24, 2024
amisadmin
left a comment
amisadmin
left a comment
Owner
There was a problem hiding this comment.
Thanks for your translation work, I will generate the corresponding locale file as soon as possible, and merge and publish to the main version.
Mkadir
commented
Mar 26, 2024
Mkadir
left a comment
Mkadir
left a comment
Contributor
Author
There was a problem hiding this comment.
Thank you for your attention and I want to ask about the main readme, I will say this while respecting your language. I would like you to look into this as well, a clear readme for the tool would definitely increase the scope of users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr for replacing some vars translated to English. I respect your language, but in production it is hard to use, becauese some vars still in Chinese after setting
LANGUAGE=en_US to .env.And that's why I'm sending this request. English is not my native language either, but Chinese is more difficult to understand than English. I hope you understand correctly.