Added handling to "?" and NULL hostnames in CLUSTER SLOTS - #104
Merged
Merged
Conversation
barshaul
force-pushed
the
fix_cluster_slots
branch
from
January 23, 2024 14:23
eed2c85 to
529ec58
Compare
shachlanAmazon
approved these changes
Jan 23, 2024
shachlanAmazon
left a comment
There was a problem hiding this comment.
minor: if we add tests only to one cluster implementation, it's better to add to the async connection, not the sync.
barshaul
force-pushed
the
fix_cluster_slots
branch
from
January 25, 2024 06:47
529ec58 to
0e2fe38
Compare
barshaul
force-pushed
the
fix_cluster_slots
branch
2 times, most recently
from
January 25, 2024 07:26
25e725f to
ae43cff
Compare
Author
@shachlanAmazon |
barshaul
force-pushed
the
fix_cluster_slots
branch
from
January 25, 2024 07:29
ae43cff to
252500a
Compare
barshaul
force-pushed
the
fix_cluster_slots
branch
from
January 25, 2024 07:30
252500a to
1314607
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the description of CLUSTER SLOTS (https://redis.io/commands/cluster-slots/):