feat: Added ability to enforce numeric map keys are encoded as numbers rather than strings#4
Closed
robdmoore wants to merge 1 commit into
Closed
feat: Added ability to enforce numeric map keys are encoded as numbers rather than strings#4robdmoore wants to merge 1 commit into
robdmoore wants to merge 1 commit into
Conversation
robdmoore
force-pushed
the
numeric-map-keys
branch
from
e220c40 to
61174e6
Compare
robdmoore
commented
Jan 30, 2024
| sortKeys | boolean | false | ||
| forceFloat32 | boolean | false | ||
| forceIntegerToFloat | boolean | false | ||
| forceNumericMapKeys | boolean | false |
Author
There was a problem hiding this comment.
This will definitely conflict with the other PRs
robdmoore
commented
Jan 30, 2024
| if (typeof key === "string") { | ||
| this.encodeString(key); | ||
| } else { | ||
| this.encodeNumber(key); |
Author
There was a problem hiding this comment.
This will automatically encode as an appropriate number (admittedly, based on int mode when that PR lands) so there isn't a lot of control over the type - potentially we want that to be configurable e.g. to always set them to uint64 or similar?
robdmoore
force-pushed
the
numeric-map-keys
branch
from
61174e6 to
3df1083
Compare
…s rather than strings
robdmoore
force-pushed
the
numeric-map-keys
branch
from
3df1083 to
3858e7d
Compare
|
Closing in favor of #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.