ateom/atelet: Remove actor template name/namespace from directories#262
Open
Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Open
ateom/atelet: Remove actor template name/namespace from directories#262Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Taahir Ahmed (ahmedtd) wants to merge 1 commit into
Conversation
Earlier in development, the actor ID was namespaced under its corresponding ActorTemplate. This is no longer the case --- Actor IDs are now unique within the substrate database, and we want to support migration of actors between ActorTemplates (for upgrade scenarios). This means that some of the the things atelet/ateom do no longer make sense: * The actor state directory no longer needs to be qualified with ActorTemplate information. * The actor logs should not be qualified with the ActorTemplate information * The ActorTemplate information no longer needs to be passed in
Benjamin Elder (BenTheElder)
left a comment
Benjamin Elder (BenTheElder)
left a comment
Collaborator
There was a problem hiding this comment.
The tests are flaky, if you rebase on main it will pickup the test fix.
We're going to have to lock in these paths at some point (to deal with atelet / ateom skew), but I don't think we're anywhere near that yet.
From AI review (discarding irrelevant bits):
tools/setup-gcp/dashboards/ate-snapshot-dashboard.json:17 and :86 do sum by (... actor_template_name ...) — these queries will collapse to a single empty-label series after deploy (broken per-template breakdown).
docs/observability.md:99 still documents actor_template_name as a label of atelet.snapshot.size.
LGTM overall.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier in development, the actor ID was namespaced under its corresponding ActorTemplate. This is no longer the case --- Actor IDs are now unique within the substrate database, and we want to support migration of actors between ActorTemplates (for upgrade scenarios).
This means that some of the the things atelet/ateom do no longer make sense: