Conversation
nedelcho-delchev-tues
requested review from
cheezus1,
d-velev,
meivantodorov and
thepiwo
d-velev
reviewed
Oct 19, 2017
Contributor
There was a problem hiding this comment.
Throwing an exception in the generate function when no solution is found and replacing the if in the Miner.Worker module with a try-catch may be cleaner (we won't match mined_header with something other than a header).
Edit: throwing an exception in this situation wouldn't be right, use cond instead of the if.
thepiwo
approved these changes
Oct 20, 2017
d-velev
approved these changes
Oct 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #60