feat: 添加golangci-lint,并修复lint检查#237
Merged
Merged
Conversation
Owner
|
感谢提交PR! |
Owner
|
@lbbniu 你好,你是否确认要提交本地的一些yml文件? |
Contributor
Author
|
确定
|
aceld
reviewed
Jun 7, 2023
Owner
|
@lbbniu 你好,大部分的格式修正已经review,非常的感谢,格式修正的也比较标准。 目前唯独一处代码修改存在逻辑问题 zinterceptor/framedocder.go //如果数据帧长度小于0,说明是个错误的数据包
if frameLength < 0 {
//内部会跳过这个数据包的字节数,并抛异常
d.failOnNegativeLengthField(in, frameLength, d.LengthFieldEndOffset)
}495行左右的这段<0的逻辑是不可以去掉的。
辛苦再做调整,重新提交一次PR吧。 |
lbbniu
force-pushed
the
feat/lbbniu/golangci-lint
branch
from
June 9, 2023 01:35
782074f to
7b96b31
Compare
Contributor
Author
|
@aceld 冲突解决,相关代码已恢复 |
Owner
|
@lbbniu Thanks,已Merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.