Implement initial set of RTD updates #885 #886 #887 #888#890
Conversation
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
Signed-off-by: John M. Horan <johnmhoran@gmail.com>
|
@AyanSinhaMahapatra -- these 4 issues are done and this PR is ready for your review and comments when you have time. Thanks in advance. 👍 |
There was a problem hiding this comment.
Thanks @johnmhoran, this resolves all the issues #885 #886 #887 #888 and all the other changes make sense too. This looks great.
Nothing major to add here, just one small additional comment unrelated to these issues,
the section title in overview : https://nexb-vulnerablecode--890.com.readthedocs.build/en/890/introduction.html#should-i-use-vulnerablecode probably can be something else instead of should I use vulnerablecode because that answer is always yes! Maybe it can be Is vulnerablecode stable? or something to that extent. But this is probably minor and I could also be wrong here.
We can also make the Recent presentations: part a new section at the end of this page as we this list will continue to grow and this is a major point also (thanks to @TG1999 @Hritik14 @pombredanne and everyone else!)
I checked the docs at https://nexb-vulnerablecode--890.com.readthedocs.build/en/890/, everything looks great there too, and I'll add issues if I see anything else here.
You need to merge the main branch into this one or rebase for this to be merged though.
But this can be merged and the issues closed! Thanks
Signed-off-by: John M. Horan johnmhoran@gmail.com
Reference: #890 Signed-off-by: John M. Horan <johnmhoran@gmail.com>
|
Ready to be merged . . . merging. |
Reference: #885
Reference: #886
Reference: #887
Reference: #888
Signed-off-by: John M. Horan johnmhoran@gmail.com