Migrate redhat importer#719
Merged
Merged
Conversation
TG1999
force-pushed
the
migration/red_hat
branch
3 times, most recently
from
May 3, 2022 17:33
a73a683 to
25fbd09
Compare
TG1999
force-pushed
the
migration/red_hat
branch
2 times, most recently
from
May 4, 2022 16:06
5a82321 to
5279666
Compare
pombredanne
reviewed
May 4, 2022
pombredanne
reviewed
May 4, 2022
pombredanne
reviewed
May 4, 2022
pombredanne
reviewed
May 4, 2022
pombredanne
reviewed
May 4, 2022
pombredanne
requested changes
May 4, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
Thanks! I posted a few review comments,
The key thing is to make sure we do not skip over data silently without logging.
TG1999
force-pushed
the
migration/red_hat
branch
7 times, most recently
from
May 11, 2022 12:19
5bba7d7 to
b6a10ed
Compare
pombredanne
approved these changes
May 13, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM... Just a few minor comments
Contributor
Author
|
Thanks @pombredanne , while I was at it, I realised severities were not displayed on UI, also fixed that. Merging it as soon it's all green! |
TG1999
force-pushed
the
migration/red_hat
branch
2 times, most recently
from
May 13, 2022 17:38
ae26ec3 to
d3316ae
Compare
Fix severities in UI Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com