Allow default improver to improve without affected packages#693
Merged
Conversation
TG1999
force-pushed
the
fix/default_improver
branch
from
April 12, 2022 17:39
f89dc23 to
c5deeb1
Compare
pombredanne
reviewed
Apr 15, 2022
pombredanne
requested changes
Apr 15, 2022
pombredanne
left a comment
pombredanne
left a comment
Member
There was a problem hiding this comment.
LGTM... but consider using file-driven tests for easier maintenance and updates. You my the nginx test branch merged first.
TG1999
force-pushed
the
fix/default_improver
branch
4 times, most recently
from
April 18, 2022 10:37
1576ec9 to
bfaa17a
Compare
pombredanne
reviewed
Apr 18, 2022
TG1999
force-pushed
the
fix/default_improver
branch
2 times, most recently
from
April 18, 2022 13:50
b346581 to
7b337cd
Compare
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
TG1999
force-pushed
the
fix/default_improver
branch
from
April 18, 2022 13:54
7b337cd to
bc94910
Compare
pombredanne
reviewed
Apr 18, 2022
| """ | ||
| default_improver = DefaultImprover() | ||
| response_file = os.path.join(TEST_DATA, f"alpine-input.json") | ||
| with open(response_file, "r") as f: |
Member
There was a problem hiding this comment.
"r" is always the default FWIW, so not needed in general
Hritik14
reviewed
Apr 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tushar Goel tushar.goel.dav@gmail.com