Fix nix setup#635
Merged
Merged
Conversation
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
Signed-off-by: Rolf Schröder <rolf.schr@gmail.com>
rolfschr
force-pushed
the
fix-nix-setup
branch
from
February 22, 2022 22:52
6935b80 to
f46de02
Compare
rolfschr
marked this pull request as ready for review
February 22, 2022 22:52
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #617. I incorporated several changes that should make the Nix setup more compatible with the rest of the code base. Mainly, the
Makefileis now used wherever possible. Fortunately, several env vars can be used to tweak the Makefile behavior (or better: the invoked commands).